試験的用にカナリア版はAndroid 16でもバックグラウンド音声を有効にできるように実装#5357
Merged
TinyKitten merged 1 commit intodevfrom Feb 19, 2026
Merged
Conversation
Contributor
📝 Walkthroughウォークスルー
変更
推定コードレビュー工数🎯 1 (Trivial) | ⏱️ ~3 minutes 関連する可能性のあるPR
推奨ラベル
ポエム
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/screens/TTSSettings.tsx`:
- Around line 117-121: コメントが実際のロジックと合っていないので、isAndroid16OrHigher の説明を「Android 16
(API 36) ではバックグラウンド音声再生が制限されるため無効化」とだけ書くのではなく、現在の条件が dev/canary
を除外するロジックになっていることを明記してください;具体的には isAndroid16OrHigher
を定義しているコメントの前後(該当する2箇所)を更新して、Platform.OS と Number(Platform.Version) のチェックに加え
isDevApp を使って dev/canary を除外している旨を簡潔に説明し、混乱を避けるために「dev/canary
を除外している」ことを明記してください。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
リリースノート